retrieve slug from slugs table if the $slugAttribute field was not changed#2688
Open
zeezo887 wants to merge 1 commit into
Open
retrieve slug from slugs table if the $slugAttribute field was not changed#2688zeezo887 wants to merge 1 commit into
zeezo887 wants to merge 1 commit into
Conversation
This was referenced Nov 19, 2024
Contributor
|
Is the disableLocaleSlug even needed before? This seems to be done already in updateOrNewSlug and I'm sure it's interfering with getOldSlug->active |
Tofandel
reviewed
Nov 19, 2024
| */ | ||
| private function getSlugValue($slugAttribute, $locale): mixed | ||
| { | ||
| return $this->wasChanged($slugAttribute) |
Contributor
There was a problem hiding this comment.
This fix doesn't work for slugs from translations, because then translations are never detected as changed and it will return the slug before change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The changes made here was to use the previous slug value if the
$slugAttributefield was not changed. By doing this, we won't have duplicate slug entries when a model is not updated via the repository.Related Issues
Fixes #2681